[PATCH] D136796: [llvm-objdump][Offload] Use common offload extraction method

Artem Belevich via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Nov 3 13:00:40 PDT 2022


tra accepted this revision.
tra added a comment.
This revision is now accepted and ready to land.

LGTM, modulo separating clang-related  change into a separate patch.



================
Comment at: clang/tools/clang-linker-wrapper/ClangLinkerWrapper.cpp:1262-1265
+    if (identify_magic((*BufferOrErr)->getBuffer()) ==
+        file_magic::elf_shared_object)
+      continue;
+
----------------
jhenderson wrote:
> This change seems not really part of the patch, since it's touching `clang` but the patch is for `llvm-objdump`.
+1 to landing this separately, possibly with a relevant test.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D136796/new/

https://reviews.llvm.org/D136796



More information about the llvm-commits mailing list