[PATCH] D135579: utils/update_mir_test_checks.py: allow checking fixedStack in .mir files

[Nicolai Hähnle via Phabricator via llvm-commits]

nhaehnle added inline comments.


================
Comment at: llvm/test/tools/UpdateTestChecks/update_mir_test_checks/Inputs/print-stack-first.mir:3-5
+# Note that this file isn't a test in itself (Inputs/ is excluded from lit's
+# test discovery). Instead, it is an input to the print-stack.test test that
+# verifies the --print-fixed-stack option of update_mir_test_checks.py.
----------------
gbossu wrote:
> nhaehnle wrote:
> > This comment isn't really necessary.
> I do agree, but this was brought to my attention that such a comment would be useful to people not too familiar with llvm's test structure. If you feel it's not needed or too verbose, I do not mind removing it.
All tests in these folders are structured the same way, so it feels strange to have the comment here. But I also don't really care, it's really a bikeshed :)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D135579/new/

https://reviews.llvm.org/D135579