[PATCH] D136858: [AArch64-SVE]: Force generating code compatible to streaming mode for sve-fixed-length tests.

Matt D. via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Nov 3 11:21:25 PDT 2022


Matt added inline comments.


================
Comment at: llvm/lib/Target/AArch64/AArch64TargetTransformInfo.h:265
+    if(ST->forceStreamingCompatibleSVE())
+      return false;
 
----------------
paulwalker-arm wrote:
> Matt wrote:
> > I wonder, would it also make sense to do that for 128-bit vectors (regardless of the streaming mode) as a (temporary?) fix for https://github.com/llvm/llvm-project/issues/56412?
> > @hassnaa-arm, @paulwalker-arm: Thoughts?
> @Matt : That's not a bug we can actually hit though is it? I mean, you have to edit the LLVM code in order to trigger the failure case?
Indeed, I'm asking in the context assuming the modification of `useSVEForFixedLengthVectors`--curious whether a similar fix is applicable, given how similar that modification is to the `forceStreamingCompatibleSVE` special case (that's the only relation to this patch). Chances are it would only be needed for `half`/`fp16`, too.



Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D136858/new/

https://reviews.llvm.org/D136858



More information about the llvm-commits mailing list