[PATCH] D137220: [LV][IVDescriptors] Fix recurrence identity element for FMin and FMax reductions.

Thu Nov 3 10:38:14 PDT 2022

karthiksenthil added a comment.

In D137220#3904940 <https://reviews.llvm.org/D137220#3904940>, @spatel wrote:

> In D137220#3903744 <https://reviews.llvm.org/D137220#3903744>, @karthiksenthil wrote:
>
>> I've added asserts in the latest diff to check that `FMF.noNaNs()` is set.
>
> Thanks - should it also assert for `noSignedZeros`?

Yes, I think it would be better to keep this assert in-sync with the checks in `RecurrenceDescriptor::isRecurrenceInstr`. I have updated the asserts and unit-tests in latest diff.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D137220/new/

https://reviews.llvm.org/D137220