[PATCH] D137324: [AMDGPU] Create new instructions in SIInstrInfo::moveToVALU
    Jay Foad via Phabricator via llvm-commits 
    llvm-commits at lists.llvm.org
       
    Thu Nov  3 08:37:43 PDT 2022
    
    
  
foad added a comment.
In D137324#3905300 <https://reviews.llvm.org/D137324#3905300>, @Joe_Nash wrote:
> This part of the commit message is worded confusingly for me.
>
> "NFCI but it does have the minor side effect of not duplicating implicit
> operands that are default for the VALU but were also present on the
> original SALU."
>
> I would probably change it to something like
>
> NFCI but it does have the minor side effect of removing duplicate implicit
> operands that were present on the
> original SALU if they are default implicit operands for the VALU.
Done, thanks.
Repository:
  rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D137324/new/
https://reviews.llvm.org/D137324
    
    
More information about the llvm-commits
mailing list