[PATCH] D137323: [InstCombine] Perform memset -> load forwarding

[Nikita Popov via Phabricator via llvm-commits]

nikic marked an inline comment as done.
nikic added inline comments.


================
Comment at: llvm/test/Transforms/InstCombine/load-store-forward.ll:282-283
 ;
   call void @llvm.memset.p0.i64(ptr %a, i8 0, i64 16, i1 false)
   %v = load i27, ptr %a
   ret i27 %v
----------------
spatel wrote:
> Do we have a negative test like this except we're 1-bit short of covering the loaded amount?
> Similarly, add a negative test where there's a store or some other interference between the memset and the load?
> Do we have a negative test like this except we're 1-bit short of covering the loaded amount?

There was load_after_memset_0_too_small, but that's using a significantly larger load. I just added load_after_memset_0_too_small_by_one_bit to have a one bit size mismatch.

> Similarly, add a negative test where there's a store or some other interference between the memset and the load?

This is covered by the load_after_memset_0_clobber test.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D137323/new/

https://reviews.llvm.org/D137323