foad added a comment. LGTM. Maybe add a test for using the same literal twice (is that allowed?) like v_permlane16_b32 v5, v1, 0x12345678, 0x12345678. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137332/new/ https://reviews.llvm.org/D137332