[PATCH] D137250: [X86] Use default attributes for more intrinsics

[Phoebe Wang via Phabricator via llvm-commits]

pengfei accepted this revision.
pengfei added a subscriber: yubing.
pengfei added a comment.
This revision is now accepted and ready to land.

LGTM.



================
Comment at: llvm/include/llvm/IR/IntrinsicsX86.td:5402-5405
+def int_x86_tdpfp16ps : ClangBuiltin<"__builtin_ia32_tdpfp16ps">,
+    DefaultAttrsIntrinsic<[], [llvm_i8_ty, llvm_i8_ty, llvm_i8_ty],
+                          [ImmArg<ArgIndex<0>>, ImmArg<ArgIndex<1>>,
+                           ImmArg<ArgIndex<2>>]>;
----------------
Actually, only this single one is AMX intrinsic. We do need a comment for the following ones. I'll do it later.
It is reasonable to take care of AMX intrinsic, so I have excluded this one in the comments :)
I think it's OK to leave it the same as other AMX intrinsics. @yubing any suggestions for these AMX intrinsics?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D137250/new/

https://reviews.llvm.org/D137250