[PATCH] D96007: [AArch64] Enable stack clash protection for AArch64 linux in clang

[Sam Tebbs via Phabricator via llvm-commits]

samtebbs added inline comments.
Herald added a subscriber: MaskRay.
Herald added a project: All.


================
Comment at: clang/lib/CodeGen/CodeGenModule.cpp:1669-1672
+    if (CodeGenOpts.StackProbeSize != 4096)
+      B.addAttribute("stack-probe-size",
+                     llvm::utostr(CodeGenOpts.StackProbeSize));
+  }
----------------
Would it be worth always setting the `stack-probe-size` attribute so that it is always correct and to avoid the risk of it going out-of-sync in case of changes to the assumed size in the backend?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D96007/new/

https://reviews.llvm.org/D96007