[PATCH] D136088: [AArch64]SME2 instructions that use ZTO operand
Cullen Rhodes via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Nov 3 03:32:25 PDT 2022
c-rhodes added inline comments.
================
Comment at: llvm/lib/Target/AArch64/AsmParser/AArch64AsmParser.cpp:4355
+ Operands.push_back(AArch64Operand::CreateReg(
+ RegNum, RegKind::LookupTable, StartLoc, getLoc(), getContext()));
+ Lex(); // Eat identifier token.
----------------
this is the same as `StartLoc` since no tokens have been lexed between calls, `Lex` should come before this
================
Comment at: llvm/lib/Target/AArch64/AsmParser/AArch64AsmParser.cpp:4365
+ if (!MCE) {
+ TokError("immediate value expected for vector index");
+ return MatchOperand_ParseFail;
----------------
this error message needs updating
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D136088/new/
https://reviews.llvm.org/D136088
More information about the llvm-commits
mailing list