[PATCH] D136796: [llvm-objdump][Offload] Use common offload extraction method

[James Henderson via Phabricator via llvm-commits]

jhenderson added a comment.

In D136796#3903393 <https://reviews.llvm.org/D136796#3903393>, @jhuber6 wrote:

> Is this good to land now?

The LLVM community practice is to wait a week between pings unless there's something urgent (and if something is urgent, please say so).

Aside from the clang bit of the patch, this seems good to me, but it would be worth another person involved with offloading to give the final thumbs up.



================
Comment at: clang/tools/clang-linker-wrapper/ClangLinkerWrapper.cpp:1262-1265
+    if (identify_magic((*BufferOrErr)->getBuffer()) ==
+        file_magic::elf_shared_object)
+      continue;
+
----------------
This change seems not really part of the patch, since it's touching `clang` but the patch is for `llvm-objdump`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D136796/new/

https://reviews.llvm.org/D136796