[PATCH] D137233: Add support for the BranchRelaxation pass
Lu Weining via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Nov 2 17:50:16 PDT 2022
SixWeining added a comment.
About the title, you'd better to add a `[LoongArch]` prefix.
================
Comment at: llvm/lib/Target/LoongArch/LoongArchInstrInfo.cpp:379
+ // TODO: When there is no scavenged register, it needs to specify a register.
+ assert(Scav != LoongArch::NoRegister && "No register is scavenged!");
+ MRI.replaceRegWith(ScratchReg, Scav);
----------------
How about when `assert = off`? Will generate wrong code if `Scav == LoongArch::NoRegister`?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D137233/new/
https://reviews.llvm.org/D137233
More information about the llvm-commits
mailing list