[PATCH] D137276: [RISCV] Add cost model for fixed broadcast shuffle

Craig Topper via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Nov 2 11:54:05 PDT 2022


craig.topper added inline comments.


================
Comment at: llvm/lib/Target/RISCV/RISCVTargetTransformInfo.cpp:273
+      return LT.first * getLMULCost(LT.second);
+    } else {
+      // Example sequence:
----------------
You can drop the else, because the if returned.


================
Comment at: llvm/lib/Target/RISCV/RISCVTargetTransformInfo.cpp:276
+      //   vrgather.vi     v9, v8, 0
+      // TODO: vrgather could be slower tha vmv.v.x. It is
+      // implementation-dependent.
----------------
tha -> than


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D137276/new/

https://reviews.llvm.org/D137276



More information about the llvm-commits mailing list