[PATCH] D137277: [AMDGPU] Skip stack-arg dbg objects while fixing the dead frame indices

Christudasan Devadasan via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Nov 2 11:30:01 PDT 2022


cdevadas created this revision.
cdevadas added reviewers: arsenm, scott.linder.
Herald added subscribers: kosarev, foad, kerbowa, hiraditya, tpr, dstuttard, yaxunl, jvesely, kzhuravl, qcolombet.
Herald added a project: All.
cdevadas requested review of this revision.
Herald added subscribers: llvm-commits, wdng.
Herald added a project: LLVM.

Both SGPR->VGPR and VGPR->AGPR spilling code give a fixup to the
spill frame indices referred in debug instructions so that they
can be entirely removed. We should skip the stack argument debug
objects while looking inside the bitvector with FI as the index
that tracks the spill indices being processed. The stack args will
have negative indices and would crash while accessing the bitvector.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D137277

Files:
  llvm/lib/Target/AMDGPU/SIFrameLowering.cpp
  llvm/lib/Target/AMDGPU/SILowerSGPRSpills.cpp
  llvm/test/CodeGen/AMDGPU/sgpr-spill-fi-skip-processing-stack-arg-dbg-value.mir
  llvm/test/CodeGen/AMDGPU/vgpr-spill-fi-skip-processing-stack-arg-dbg-value.mir

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D137277.472710.patch
Type: text/x-patch
Size: 6989 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20221102/5221427c/attachment.bin>


More information about the llvm-commits mailing list