[PATCH] D136415: [LSR] Check if terminating value is safe to expand before transformation

[Zaara Syeda via Phabricator via llvm-commits]

syzaara added inline comments.


================
Comment at: llvm/lib/Transforms/Scalar/LoopStrengthReduce.cpp:6861
       // TermValue = Start + Stride * (BackedgeCount + 1)
       const SCEV *TermValueS = SE.getAddExpr(
           AddRec->getOperand(0),
----------------
It seems like we are doing this SCEV expansion already in IsToHelpFold. Could we just return TermValueS from there rather than redoing the SCEV calculation again? 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D136415/new/

https://reviews.llvm.org/D136415