[PATCH] D134195: [PowerPC] XCOFF exception section support on the integrated assembler path

[Paul Scoropan via Phabricator via llvm-commits]

pscoro marked 7 inline comments as done.
pscoro added inline comments.


================
Comment at: llvm/test/CodeGen/PowerPC/builtins-ppc-xlcompat-trap-annotations-td.ll:7
 ; RUN:   --ppc-asm-full-reg-names -mcpu=pwr8 < %s | FileCheck %s -check-prefix=AIX
-; RUN: not --crash llc -verify-machineinstrs -mtriple=powerpc64-unknown-aix \
-; RUN:   --ppc-asm-full-reg-names -mcpu=pwr8 --filetype=obj -o /dev/null %s 2>&1 | FileCheck %s -check-prefix=OBJ
----------------
shchenz wrote:
> shchenz wrote:
> > We should not remove the RUN line as it is the only one test for -filetype=obj. Maybe we can modify the check to a simple check, for example, `; OBJ-LABEL: test__trapd_annotation:` to check that the case does not crash in obj mode now?
> This comment seems not be addressed?
I can't add OBJ-LABEL because this isnt checking assembly labels but I added the equivalent for object files


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D134195/new/

https://reviews.llvm.org/D134195