[PATCH] D136448: [AMDGPU][GISel] Add llvm.amdgcn.icmp selection

Pierre van Houtryve via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Nov 2 08:04:44 PDT 2022


Pierre-vh added inline comments.


================
Comment at: llvm/lib/Target/AMDGPU/AMDGPUInstructionSelector.cpp:1237
+  //  in i1 handling between GISel and DAG.
+  if (Size == 1)
+    Size = 32;
----------------
This is obviously wrong as we only want to compare the first bit in each VGPR, but I don't know what instruction to use here yet.

Which instruction do I need to use here? V_CNDMASK ?



Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D136448/new/

https://reviews.llvm.org/D136448



More information about the llvm-commits mailing list