[PATCH] D124325: [AArch64][SVE] Support logical operation BIC with DestructiveBinary patterns

Wed Nov 2 07:34:53 PDT 2022

paulwalker-arm added inline comments.

================
Comment at: llvm/lib/Target/AArch64/AArch64ExpandPseudoInsts.cpp:591-592
+  // z0.b, p0/z, z0.b; lsl z0.b, p0/m, z0.b, #0;
+  if (DType == AArch64::DestructiveBinary &&
+      DstReg == MI.getOperand(SrcIdx).getReg()) {
+    BuildMI(MBB, MBBI, MI.getDebugLoc(), TII->get(LSLZero))
----------------
Allen wrote:
> paulwalker-arm wrote:
> > If you keep the above code then does `if (!DOPRegIsUnique)` work here? and as mentioned I believe it should sit with the `if (FalseZero)` block.
> * No, the above code is only active when the **#ifndef NDEBUG** is true, so it is depend on our configue.
> 
> * Apply your comment and move into the **if (FalseZero)** block, thanks
Sure, but what I'm suggesting is that the code is no longer `DEBUG` only as we now have a real world use for it.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D124325/new/

https://reviews.llvm.org/D124325