[PATCH] D131628: [LangRef] Add description for nocallback attribute

Wed Nov 2 04:49:26 PDT 2022

xbolva00 added a comment.

In D131628#3901837 <https://reviews.llvm.org/D131628#3901837>, @nlopes wrote:

> In D131628#3900066 <https://reviews.llvm.org/D131628#3900066>, @mysterymath wrote:
>
>> @nlopes, can we create a separate issue for finding the right semantics, and move forward by making this change describe as accurately as possible the current state of affairs?
>> Given that the original patch has been in LLVM for a long time, spanning many versions, it seems like we'd want to rectify the undocumentedness of the attribute ASAP, then work towards changing its semantics afterwards.
>
> I think the effort of doing it right once is lower than doing it twice, but do as you see fit. As long as things get fixed..
> Google doesn't have a good track record in fixing "temporary" hacks. The first time I approved one of such hacks was more than 10 years ago and the code is still there and google refuses to remove it. The other one had to be one of my students to fix it. Hence I'm a bit skeptical about fixing things "afterwards".

It would be good to have a action plan like “if not fixed before llvm 16 branch date, revert it fully” to avoid keeping such stuff live for years (learn from previous mistakes, as you said).

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D131628/new/

https://reviews.llvm.org/D131628