[PATCH] D137242: [llvm-debuginfo-analyzer] Remove '--print=sizes' in test case.

Carlos Alberto Enciso via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Nov 2 04:11:19 PDT 2022


CarlosAlbertoEnciso created this revision.
CarlosAlbertoEnciso added reviewers: probinson, dblaikie, psamolysov, jryans, Orlando, vitalybuka.
CarlosAlbertoEnciso added projects: debug-info, LLVM.
Herald added subscribers: manas, ASDenysPetrov, dkrupp, donat.nagy, Szelethus, a.sidorin, baloghadamsoftware, kristof.beyls.
Herald added a project: All.
CarlosAlbertoEnciso requested review of this revision.
Herald added a subscriber: llvm-commits.

The use of '--print=sizes' produces an invalid output
on the following platforms/systems:

clang-armv7-vfpv3-2stage
https://lab.llvm.org/buildbot/#/builders/182/builds/4232

clang-armv7-global-isel
https://lab.llvm.org/buildbot/#/builders/186/builds/9519

clang-armv7-2stage
https://lab.llvm.org/buildbot/#/builders/187/builds/9483

The same problem reported building 32-bit multilib on amd64.

- Removed the '--print=sizes' from the test.
- Created https://github.com/llvm/llvm-project/issues/58758


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D137242

Files:
  llvm/test/tools/llvm-debuginfo-analyzer/DWARF/06-dwarf-full-logical-view.test


Index: llvm/test/tools/llvm-debuginfo-analyzer/DWARF/06-dwarf-full-logical-view.test
===================================================================
--- llvm/test/tools/llvm-debuginfo-analyzer/DWARF/06-dwarf-full-logical-view.test
+++ llvm/test/tools/llvm-debuginfo-analyzer/DWARF/06-dwarf-full-logical-view.test
@@ -1,10 +1,25 @@
 ; REQUIRES: x86-registered-target
 
-; FIXME: Test failure https://reviews.llvm.org/D125783
-; UNSUPPORTED: arm
-
 ; Test case 6 - Full logical view
 
+; The original test case used the '--print=all' option which causes
+; issues on the following platforms:
+;
+;  clang-armv7-vfpv3-2stage
+;  https://lab.llvm.org/buildbot/#/builders/182/builds/4232
+;
+;  clang-armv7-global-isel
+;  https://lab.llvm.org/buildbot/#/builders/186/builds/9519
+;
+;  clang-armv7-2stage
+;  https://lab.llvm.org/buildbot/#/builders/187/builds/9483
+;
+; 32-bit multilib on amd64
+;
+; Created https://github.com/llvm/llvm-project/issues/58758
+;
+; Remove the '--print=sizes' for this specific test.
+
 ; test.cpp
 ;  1  using INTPTR = const int *;
 ;  2  int foo(INTPTR ParamPtr, unsigned ParamUnsigned, bool ParamBool) {
@@ -22,7 +37,7 @@
 ; operands, linkage names, etc.
 
 ; RUN: llvm-debuginfo-analyzer --attribute=all \
-; RUN:                         --print=all \
+; RUN:                         --print=elements,warnings,summary \
 ; RUN:                         %p/Inputs/test-dwarf-clang.o 2>&1 | \
 ; RUN: FileCheck --strict-whitespace -check-prefix=ONE %s
 
@@ -98,13 +113,3 @@
 ; ONE-NEXT: Lines           25         25
 ; ONE-NEXT: -----------------------------
 ; ONE-NEXT: Total           37         37
-; ONE-EMPTY:
-; ONE-NEXT: Scope Sizes:
-; ONE-NEXT:        189 (100.00%) : [0x000000000b][001]              {CompileUnit} 'test.cpp'
-; ONE-NEXT:        110 ( 58.20%) : [0x000000002a][002]      2         {Function} extern not_inlined 'foo' -> [0x0000000099]'int'
-; ONE-NEXT:         27 ( 14.29%) : [0x0000000071][003]                  {Block}
-; ONE-EMPTY:
-; ONE-NEXT: Totals by lexical level:
-; ONE-NEXT: [001]:        189 (100.00%)
-; ONE-NEXT: [002]:        110 ( 58.20%)
-; ONE-NEXT: [003]:         27 ( 14.29%)


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D137242.472569.patch
Type: text/x-patch
Size: 2158 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20221102/e6477eee/attachment.bin>


More information about the llvm-commits mailing list