[llvm] 87d98a7 - [hwasan] Remove no-op setDSOLocal. NFC
Fangrui Song via llvm-commits
llvm-commits at lists.llvm.org
Wed Nov 2 00:17:21 PDT 2022
Author: Fangrui Song
Date: 2022-11-02T00:17:16-07:00
New Revision: 87d98a73005d42dc233c4f5bf191fc0496193716
URL: https://github.com/llvm/llvm-project/commit/87d98a73005d42dc233c4f5bf191fc0496193716
DIFF: https://github.com/llvm/llvm-project/commit/87d98a73005d42dc233c4f5bf191fc0496193716.diff
LOG: [hwasan] Remove no-op setDSOLocal. NFC
PrivateLinkage and HiddenVisibility are implicitly dso_local.
Added:
Modified:
llvm/lib/Transforms/Instrumentation/HWAddressSanitizer.cpp
Removed:
################################################################################
diff --git a/llvm/lib/Transforms/Instrumentation/HWAddressSanitizer.cpp b/llvm/lib/Transforms/Instrumentation/HWAddressSanitizer.cpp
index eb54069e74dba..2a4b640129d84 100644
--- a/llvm/lib/Transforms/Instrumentation/HWAddressSanitizer.cpp
+++ b/llvm/lib/Transforms/Instrumentation/HWAddressSanitizer.cpp
@@ -497,12 +497,10 @@ void HWAddressSanitizer::createHwasanCtorComdat() {
new GlobalVariable(M, Int8Arr0Ty, true, GlobalVariable::ExternalLinkage,
nullptr, "__start_hwasan_globals");
Start->setVisibility(GlobalValue::HiddenVisibility);
- Start->setDSOLocal(true);
auto Stop =
new GlobalVariable(M, Int8Arr0Ty, true, GlobalVariable::ExternalLinkage,
nullptr, "__stop_hwasan_globals");
Stop->setVisibility(GlobalValue::HiddenVisibility);
- Stop->setDSOLocal(true);
// Null-terminated so actually 8 bytes, which are required in order to align
// the note properly.
@@ -516,7 +514,6 @@ void HWAddressSanitizer::createHwasanCtorComdat() {
Note->setSection(".note.hwasan.globals");
Note->setComdat(NoteComdat);
Note->setAlignment(Align(4));
- Note->setDSOLocal(true);
// The pointers in the note need to be relative so that the note ends up being
// placed in rodata, which is the standard location for notes.
More information about the llvm-commits
mailing list