[PATCH] D136164: [MemorySSA] Use BatchAA for clobber walker

[Alina Sbirlea via Phabricator via llvm-commits]

asbirlea added a comment.

It seems unnecessary to force all uses to instantiate and pass the BatchAA.
Can this remain part of the ClobberWalkerBase instead? Default the calls to getClobberingMemoryAccess to instantiate a BatchAA internally and pass to the ClobberWalker.
Then, there can be an additional API added to override the above behavior when useful (known as safe): either passing a given BatchAA like current patch, or, keeping a BatchAA in the ClobberWalker itself instead of the AA, and being able to "set" it to not re-initialize it on each call (and perhaps "reset" to reseting each time).
What do you think?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D136164/new/

https://reviews.llvm.org/D136164