[PATCH] D136855: [Binary] Support extracting offloading files from COFF
Reid Kleckner via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Nov 1 15:46:17 PDT 2022
rnk accepted this revision.
rnk added inline comments.
This revision is now accepted and ready to land.
================
Comment at: llvm/lib/Object/OffloadBinary.cpp:77
+ if (Obj.isELF() &&
+ static_cast<ELFSectionRef>(Sec).getType() != ELF::SHT_LLVM_OFFLOADING)
continue;
----------------
static_cast doesn't seem idiomatic, calling the constructor like `ELFSectionRef(Sec).getType() != ...` seems more straightforward.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D136855/new/
https://reviews.llvm.org/D136855
More information about the llvm-commits
mailing list