[PATCH] D136201: [InstCombine] Handle PHI nodes when eliminating constant memcpy

Anshil Gandhi via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Nov 1 14:06:27 PDT 2022


gandhi21299 added a comment.

@nikic Since alloca instructions are iterated more than once, shouldn't the `Worklist` under `PointerReplacer` remove instructions that have already been //replaced// (new instruction inserted without removing the old instruction)? The first function goes through a strange transformation when opaque pointers are used, where the `replace(Instruction&)` function is called on a GEP instruction which was already replaced in a previous instruction. This somehow causes the removal of the new GEP instruction.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D136201/new/

https://reviews.llvm.org/D136201



More information about the llvm-commits mailing list