[PATCH] D137046: Allows scalable vectors in ComputeNumSignBits and isKnownNonNull

[Philip Reames via Phabricator via llvm-commits]

reames marked an inline comment as done.
reames added inline comments.


================
Comment at: llvm/lib/Analysis/ValueTracking.cpp:2568
     // as casts that can alter the value, e.g., AddrSpaceCasts.
-    if (Q.DL.getTypeSizeInBits(I->getOperand(0)->getType()).getFixedSize() <=
+    if (!isa<ScalableVectorType>(I->getOperand(0)->getType()) &&
+        !isa<ScalableVectorType>(I->getType()) &&
----------------
reames wrote:
> paulwalker-arm wrote:
> > Minor quibble but this is implied by the following !isa<ScalableVectorType>(I->getType()) check.
> I agree.  This isn't checked by castIsValid which is what I'd expected, but the verifier does directly compare the element counts which should fail if only one is scalable.  Will remove in a follow up commit.  
Done. 9472a81


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D137046/new/

https://reviews.llvm.org/D137046