[PATCH] D136944: [AMDGPU] Enable `s_sendmsg_rtn` selection with `+gfx11-insts`

Jay Foad via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Nov 1 12:10:14 PDT 2022


foad added a comment.

In D136944#3898249 <https://reviews.llvm.org/D136944#3898249>, @arsenm wrote:

> In D136944#3891713 <https://reviews.llvm.org/D136944#3891713>, @foad wrote:
>
>> I do think this is much nicer than the previous approach of generating V_ILLEGAL instead of diagnosing illegal intrinsics (D123693 <https://reviews.llvm.org/D123693>).
>
> We can't really avoid the V_ILLEGAL case if the instruction isn't encodable for the end subtarget.

Doesn't this patch solve that by adding stuff to pseudoToMCOpcode to encode it for GFX11 if it can't find an encoding for the real subtarget?

> There's 3 different ways instructions can be illegal

What are they?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D136944/new/

https://reviews.llvm.org/D136944



More information about the llvm-commits mailing list