[PATCH] D136927: [AMDGPU] Fix GCNDownwardRPTracker::advanceBeforeNext at the end of MBB

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Nov 1 11:06:05 PDT 2022


arsenm accepted this revision.
arsenm added inline comments.
This revision is now accepted and ready to land.


================
Comment at: llvm/lib/Target/AMDGPU/GCNRegPressure.cpp:345
 
-  NextMI = skipDebugInstructionsForward(NextMI, MBBEnd);
-  if (NextMI == MBBEnd)
----------------
vpykhtin wrote:
> rampitec wrote:
> > I think you still need to skip debug instructions.
> NextMI is already skipped debug instructions either in reset or advanceToNext. I just using slot index before NextMI to skip debug instruction during liveness test.
Maybe add an assert it's not a debug instruction 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D136927/new/

https://reviews.llvm.org/D136927



More information about the llvm-commits mailing list