[PATCH] D137167: [AArch64][SVE2] Add the SVE2.1 ld1q gather & st1q scatter instructions

Paul Walker via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Nov 1 10:48:11 PDT 2022


paulwalker-arm accepted this revision.
paulwalker-arm added a comment.
This revision is now accepted and ready to land.

A request for some extra negative tests but otherwise looks good to me.



================
Comment at: llvm/test/MC/AArch64/SVE2p1/ld1q-diagnostics.s:2
+// RUN: not llvm-mc -triple=aarch64 -show-encoding -mattr=+sve2p1 2>&1 < %s | FileCheck %s
+
+// --------------------------------------------------------------------------//
----------------
I think it's worth having negative tests for
```
ld1q {z0.q}, p0/z, [z0.d, sp]
ld1q {z0.q}, p0/z, [x0, z0.d]
```


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D137167/new/

https://reviews.llvm.org/D137167



More information about the llvm-commits mailing list