[PATCH] D132436: [AMDGPU][SIFrameLowering] Unify PEI SGPR spill saves and restores (NFC)
Matt Arsenault via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Nov 1 10:42:16 PDT 2022
arsenm accepted this revision.
arsenm added inline comments.
================
Comment at: llvm/lib/Target/AMDGPU/SIFrameLowering.cpp:197
+ if (IsProlog) {
+ LiveRegs.addLiveIns(MBB);
+ } else {
----------------
Really we ought to be stepping back from the end of the entry block and always using reverse liveness (but I guess you're just moving this function, so that's a separate change)
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D132436/new/
https://reviews.llvm.org/D132436
More information about the llvm-commits
mailing list