[PATCH] D136855: [Binary] Support extracting offloading files from COFF

Joseph Huber via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Nov 1 10:36:30 PDT 2022


jhuber6 added a comment.

In D136855#3899604 <https://reviews.llvm.org/D136855#3899604>, @tra wrote:

> Added @rnk for Windows know-how.

A question I have for COFF, is if the only way to identify these sections would be via the name. For ELF we use a custom section type to easily identify the fat binary section, but it doesn't seem that there is a COFF equivalent. I thought about checking for the `IMAGE_SCN_LNK_REMOVE` and  `IMAGE_SCN_MEM_DISCARDABLE` flags, but that's not guaranteed to be correct.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D136855/new/

https://reviews.llvm.org/D136855



More information about the llvm-commits mailing list