[PATCH] D137046: Allows scalable vectors in ComputeNumSignBits and isKnownNonNull

Paul Walker via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Nov 1 09:55:52 PDT 2022


paulwalker-arm added inline comments.


================
Comment at: llvm/lib/Analysis/ValueTracking.cpp:2568
     // as casts that can alter the value, e.g., AddrSpaceCasts.
-    if (Q.DL.getTypeSizeInBits(I->getOperand(0)->getType()).getFixedSize() <=
+    if (!isa<ScalableVectorType>(I->getOperand(0)->getType()) &&
+        !isa<ScalableVectorType>(I->getType()) &&
----------------
Minor quibble but this is implied by the following !isa<ScalableVectorType>(I->getType()) check.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D137046/new/

https://reviews.llvm.org/D137046



More information about the llvm-commits mailing list