[PATCH] D136438: [AArch64][SVE] Extend PTEST_ANY(X=OP(PG, ...), X) -> PTEST_ANY(PG, X)) instcombine

Peter Waller via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Nov 1 09:05:11 PDT 2022


peterwaller-arm accepted this revision.
peterwaller-arm added a comment.
This revision is now accepted and ready to land.

LGTM, with one minor nit.



================
Comment at: llvm/lib/Target/AArch64/AArch64TargetTransformInfo.cpp:1001
 
   // Transform PTEST_ANY(X=OP(PG,...), X) -> PTEST_ANY(PG, X)).
   // Later optimizations may rewrite sequence to use the flag-setting variant
----------------
I see an extra ) on the right there, which I guess also made it into the commit title and the tests.


================
Comment at: llvm/test/Transforms/InstCombine/AArch64/sve-intrinsics-ptest.ll:71
 
+; Rewrite PTEST_ANY(X=OP(PG,...), X) -> PTEST_ANY(PG, X)).
+
----------------
Nit: Extraneous ).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D136438/new/

https://reviews.llvm.org/D136438



More information about the llvm-commits mailing list