[PATCH] D137152: Fix crash when using embedded DWARF-5 debugging info

Guilherme Amadio via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Nov 1 06:59:13 PDT 2022


amadio updated this revision to Diff 472288.
amadio added a comment.

Updated due to clang-format failure.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D137152/new/

https://reviews.llvm.org/D137152

Files:
  llvm/include/llvm/IR/DebugInfoMetadata.h


Index: llvm/include/llvm/IR/DebugInfoMetadata.h
===================================================================
--- llvm/include/llvm/IR/DebugInfoMetadata.h
+++ llvm/include/llvm/IR/DebugInfoMetadata.h
@@ -618,7 +618,9 @@
     return StringRefChecksum;
   }
   Optional<StringRef> getSource() const {
-    return Source ? Optional<StringRef>((*Source)->getString()) : None;
+    if (!Source || !*Source)
+      return None;
+    return Optional<StringRef>((*Source)->getString());
   }
 
   MDString *getRawFilename() const { return getOperandAs<MDString>(0); }


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D137152.472288.patch
Type: text/x-patch
Size: 566 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20221101/4b55dbfb/attachment-0001.bin>


More information about the llvm-commits mailing list