[PATCH] D136950: [XCOFF] change the decoding of External symbol's function auxiliary entry in XCOFF32 for llvm-readobj

Digger Lin via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Nov 1 06:44:45 PDT 2022


DiggerLin marked 2 inline comments as done.
DiggerLin added inline comments.


================
Comment at: llvm/tools/llvm-readobj/XCOFFDumper.cpp:625
     for (int I = 1; I <= NumberOfAuxEntries; I++) {
-      if ((I == NumberOfAuxEntries && !Obj.is64Bit()) ||
-          !SymbolEntRef.isFunction())
+      if (I == NumberOfAuxEntries && !Obj.is64Bit())
         break;
----------------
hubert.reinterpretcast wrote:
> I think we should have functional tests that demonstrate the new behaviour.
I added symbol which has two function auxiliary and a Csect auxiliary entries in the tools/llvm-readobj/XCOFF/symbols.test


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D136950/new/

https://reviews.llvm.org/D136950



More information about the llvm-commits mailing list