[PATCH] D136589: [AArch64] Add support for the Cortex-X3 CPU

Tue Nov 1 06:01:49 PDT 2022

dmgreen added a comment.

Thanks. What was wrong with the v9-A features?

================
Comment at: llvm/unittests/Support/TargetParserTest.cpp:1083
+                             AArch64::AEK_SVE | AArch64::AEK_SVE2 |
+                             AArch64::AEK_SVE2BITPERM | AArch64::AEK_SB |
+                             AArch64::AEK_PROFILE | AArch64::AEK_PERFMON |
----------------
Should SSBS be included in here? As far as I understand it is enabled by default in 8.5-A. That should mean it's included automatically, but that can be said for a lot of the other features here too.
Same for AEK_FLAGM, which I noticed as a difference between A715 and X3.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D136589/new/

https://reviews.llvm.org/D136589