[PATCH] D136361: [AArch64][SME] Disable GlobalISel/FastISel for SME functions.

Sander de Smalen via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Nov 1 03:42:57 PDT 2022


sdesmalen marked 2 inline comments as done.
sdesmalen added inline comments.


================
Comment at: llvm/test/CodeGen/AArch64/sme-disable-gisel-fisel.ll:251
+; CHECK-FISEL-NEXT:    bl za_shared_callee
+; CHECK-FISEL-NEXT:    smstart za
+; CHECK-FISEL-NEXT:    mrs x8, TPIDR2_EL0
----------------
david-arm wrote:
> Not sure if this is caused by your patch or not, but it looks a bit odd. Perhaps I'm missing something, but it seems to be treating `za_shared_callee` as a private-ZA function and setting up a lazy-save + restore. 
That was because `za_shared_callee` had `aarch64_pstate_sm_shared` instead of `aarch64_pstate_za_shared` as it's attribute. Thanks for pointing out!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D136361/new/

https://reviews.llvm.org/D136361



More information about the llvm-commits mailing list