[PATCH] D136090: Handle errors in expansion of response files

Tue Nov 1 03:23:32 PDT 2022

uabelho added a comment.

Hello,

I'm wondering if this is really working as expected/intended.

With this patch, if I do

  clang empty.c @atfileesc.txt -dry-run

on an empty file empty.c and atfileesc.txt containing just

  -I @name-with-at/

then I get the following error

  cannot open file: /repo/uabelho/main-github/llvm/atfileesc.txt
  Program aborted due to an unhandled Error:
  cannot open file: /repo/uabelho/main-github/llvm/atfileesc.txt
  PLEASE submit a bug report to https://github.com/llvm/llvm-project/issues/ and include the crash backtrace, preprocessed source, and associated run script.
  Stack dump:
  0.	Program arguments: build-all/bin/clang empty.c @atfileesc.txt -dry-run
   #0 0x0000000002fc9873 llvm::sys::PrintStackTrace(llvm::raw_ostream&, int) (build-all/bin/clang+0x2fc9873)
   #1 0x0000000002fc758e llvm::sys::RunSignalHandlers() (build-all/bin/clang+0x2fc758e)
   #2 0x0000000002fc9bf6 SignalHandler(int) (build-all/bin/clang+0x2fc9bf6)
   #3 0x00007f678e7ae630 __restore_rt (/lib64/libpthread.so.0+0xf630)
   #4 0x00007f678bef5387 raise (/lib64/libc.so.6+0x36387)
   #5 0x00007f678bef6a78 abort (/lib64/libc.so.6+0x37a78)
   #6 0x0000000002f39d00 llvm::Error::fatalUncheckedError() const (build-all/bin/clang+0x2f39d00)
   #7 0x00000000009d5e3a clang_main(int, char**) (build-all/bin/clang+0x9d5e3a)
   #8 0x00007f678bee1555 __libc_start_main (/lib64/libc.so.6+0x22555)
   #9 0x00000000009d233b _start (build-all/bin/clang+0x9d233b)
  Abort (core dumped)

Note that the file it is complaining about indeed exists:

  -> ls -l /repo/uabelho/main-github/llvm/atfileesc.txt
  -rw-r--r-- 1 uabelho eusers 18 Nov  1 11:15 /repo/uabelho/main-github/llvm/atfileesc.txt

and as I wrote above it contains

  -> cat /repo/uabelho/main-github/llvm/atfileesc.txt
  -I @name-with-at/

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D136090/new/

https://reviews.llvm.org/D136090