[PATCH] D137144: [llvm-config] Remove --src-root option

[Michał Górny via Phabricator via llvm-commits]

mgorny created this revision.
mgorny added reviewers: MaskRay, serge-sans-paille, phosek, tstellar.
Herald added a subscriber: StephenFan.
Herald added a project: All.
mgorny requested review of this revision.
Herald added a project: LLVM.

Remove the `--src-root` option from the deprecated llvm-config tool.
None of the llvm-project projects use this option anymore. The value
was only meaningful for in-tree use and usually became no longer correct
once LLVM was installed -- either because it was built in a temporary
directory, or installed from a binary package and built on a different
system entirely.  Therefore, third-party tools could not have been
relying on it anyway.

The LLVM_SRC_ROOT #define is left intact, as it is used to compute
includedir when llvm-config is used in-source.


https://reviews.llvm.org/D137144

Files:
  llvm/docs/CommandGuide/llvm-config.rst
  llvm/tools/llvm-config/llvm-config.cpp


Index: llvm/tools/llvm-config/llvm-config.cpp
===================================================================
--- llvm/tools/llvm-config/llvm-config.cpp
+++ llvm/tools/llvm-config/llvm-config.cpp
@@ -234,7 +234,6 @@
   --obj-root        Print the object root used to build LLVM.\n\
   --prefix          Print the installation prefix.\n\
   --shared-mode     Print how the provided components can be collectively linked (`shared` or `static`).\n\
-  --src-root        Print the source root LLVM was built from.\n\
   --system-libs     System Libraries needed to link against LLVM components.\n\
   --targets-built   List of all targets currently built.\n\
   --version         Print LLVM version.\n\
@@ -592,8 +591,6 @@
         PrintSharedMode = true;
       } else if (Arg == "--obj-root") {
         OS << ActivePrefix << '\n';
-      } else if (Arg == "--src-root") {
-        OS << LLVM_SRC_ROOT << '\n';
       } else if (Arg == "--ignore-libllvm") {
         LinkDyLib = false;
         LinkMode = BuiltSharedLibs ? LinkModeShared : LinkModeAuto;
Index: llvm/docs/CommandGuide/llvm-config.rst
===================================================================
--- llvm/docs/CommandGuide/llvm-config.rst
+++ llvm/docs/CommandGuide/llvm-config.rst
@@ -130,10 +130,6 @@
 
  Print how the provided components can be collectively linked (`shared` or `static`).
 
-**--src-root**
-
- Print the source root from which LLVM was built.
-
 **--system-libs**
 
  Print all the system libraries needed to link against the specified LLVM


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D137144.472212.patch
Type: text/x-patch
Size: 1536 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20221101/9d827555/attachment.bin>