[PATCH] D137013: [asan] Use proper shadow offset for loongarch64 in instrumentation passes

[WÁNG Xuěruì via Phabricator via llvm-commits]

xen0n added a comment.

I've lightly edited the patch summary to fix some grammatical nits. Please check it out so you'll write better commit messages next time and not need such touching ;-)



================
Comment at: llvm/lib/Transforms/Instrumentation/AddressSanitizer.cpp:581
+  // is a power of two, but on ppc64 and loongarch64 we have to use add since
+  // the shadow offset is not necessary 1/8-th of the address space.  On
+  // SystemZ, we could OR the constant in a single instruction, but it's more
----------------
Nit, since you've touched this line: `not necessarily`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D137013/new/

https://reviews.llvm.org/D137013