[PATCH] D136944: [AMDGPU] Enable `s_sendmsg_rtn` selection with `+gfx11-insts`

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Oct 31 19:33:42 PDT 2022


arsenm added a comment.

In D136944#3891707 <https://reviews.llvm.org/D136944#3891707>, @foad wrote:

> I don't really like the fact that we are left with both isGFX11Plus and HasGFX11Insts, and no clear way to know which one to use, unless you happen to know what instructions some ROCm libraries are relying on.
>
> Seems reasonable apart from that.

Generation checks should always be "wrong". Ideally the hardware would move in nice, modular feature based changes but that's not what has happened


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D136944/new/

https://reviews.llvm.org/D136944



More information about the llvm-commits mailing list