[PATCH] D136614: llvm-reduce: Report file opening errors

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Oct 31 18:37:08 PDT 2022


arsenm added a comment.

In D136614#3897470 <https://reviews.llvm.org/D136614#3897470>, @aeubanks wrote:

> oh I guess if there's an error opening the file initially, it'll stay as that error even attempting to write to it?

No, it's an assert to write to the failed open file. This ends up checking after open and after close. The problem was the text and bitcode paths were duplicating the opening, and the text path didn't check


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D136614/new/

https://reviews.llvm.org/D136614



More information about the llvm-commits mailing list