[PATCH] D136914: [llvm][ocaml] Replace deprecated C functions in OCaml bindings

[Alan via Phabricator via llvm-commits]

alan added inline comments.


================
Comment at: llvm/bindings/ocaml/llvm/llvm_ocaml.c:997
 
 /* llvalue -> llvalue array -> llvalue */
+LLVMValueRef llvm_const_in_bounds_gep(LLVMTypeRef Ty, LLVMValueRef ConstantVal,
----------------
@nikic I realized that I forgot to update this comment with the new OCaml type signature in this patch. (An `lltype` should be added as the first argument.) I still have that pending patch where I rewrite the bindings to not use naked pointers, and when I rebased that patch after this one was merged, I fixed the comment here to have the right OCaml type. Because that patch rewrites the bindings, I had taken the opportunity to fix a bunch of "small" mistakes that I found in the bindings (e.g. wrong OCaml type signatures in C comments). Is it okay for me to be fixing these kinds of mistakes in that big patch? Or should I make another patch to fix these small mistakes?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D136914/new/

https://reviews.llvm.org/D136914