[PATCH] D135898: [wasm-ld] Allow importing/exporting the output module's memory with arbitrary names

[Florian Mayer via Phabricator via llvm-commits]

fmayer added a comment.

This broke our build bots: https://lab.llvm.org/buildbot/#/builders/19/builds/13332/steps/25/logs/stdio

  FAILED: tools/lld/wasm/CMakeFiles/lldWasm.dir/Driver.cpp.o 
  /home/buildbots/ppc64le-sanitizer/sanitizer-ppc64le/build/clang_build/bin/clang++  -DGTEST_HAS_RTTI=0 -D_DEBUG -D_GNU_SOURCE -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -Itools/lld/wasm -I/home/buildbots/ppc64le-sanitizer/sanitizer-ppc64le/build/llvm-project/lld/wasm -I/home/buildbots/ppc64le-sanitizer/sanitizer-ppc64le/build/llvm-project/lld/include -Itools/lld/include -Iinclude -I/home/buildbots/ppc64le-sanitizer/sanitizer-ppc64le/build/llvm-project/llvm/include -gmlt -fPIC -fno-semantic-interposition -fvisibility-inlines-hidden -Werror -Werror=date-time -Werror=unguarded-availability-new -Wall -Wextra -Wno-unused-parameter -Wwrite-strings -Wcast-qual -Wmissing-field-initializers -pedantic -Wno-long-long -Wc++98-compat-extra-semi -Wimplicit-fallthrough -Wcovered-switch-default -Wno-noexcept-type -Wnon-virtual-dtor -Wdelete-non-virtual-dtor -Wsuggest-override -Wno-comment -Wstring-conversion -Wmisleading-indentation -Wctad-maybe-unsupported -fdiagnostics-color -ffunction-sections -fdata-sections -O3 -DNDEBUG    -fno-exceptions -fno-rtti -UNDEBUG -std=c++17 -MD -MT tools/lld/wasm/CMakeFiles/lldWasm.dir/Driver.cpp.o -MF tools/lld/wasm/CMakeFiles/lldWasm.dir/Driver.cpp.o.d -o tools/lld/wasm/CMakeFiles/lldWasm.dir/Driver.cpp.o -c /home/buildbots/ppc64le-sanitizer/sanitizer-ppc64le/build/llvm-project/lld/wasm/Driver.cpp
  /home/buildbots/ppc64le-sanitizer/sanitizer-ppc64le/build/llvm-project/lld/wasm/Driver.cpp:533:30: error: 'hasValue' is deprecated: Use has_value instead. [-Werror,-Wdeprecated-declarations]
      if (config->memoryExport.hasValue()) {
                               ^~~~~~~~
                               has_value
  /home/buildbots/ppc64le-sanitizer/sanitizer-ppc64le/build/llvm-project/llvm/include/llvm/ADT/Optional.h:325:3: note: 'hasValue' has been explicitly marked deprecated here
    LLVM_DEPRECATED("Use has_value instead.", "has_value")
    ^
  /home/buildbots/ppc64le-sanitizer/sanitizer-ppc64le/build/llvm-project/llvm/include/llvm/Support/Compiler.h:143:50: note: expanded from macro 'LLVM_DEPRECATED'
  #define LLVM_DEPRECATED(MSG, FIX) __attribute__((deprecated(MSG, FIX)))
                                                   ^
  /home/buildbots/ppc64le-sanitizer/sanitizer-ppc64le/build/llvm-project/lld/wasm/Driver.cpp:536:31: error: 'hasValue' is deprecated: Use has_value instead. [-Werror,-Wdeprecated-declarations]
      if (!config->memoryImport.hasValue()) {
                                ^~~~~~~~
                                has_value
  /home/buildbots/ppc64le-sanitizer/sanitizer-ppc64le/build/llvm-project/llvm/include/llvm/ADT/Optional.h:325:3: note: 'hasValue' has been explicitly marked deprecated here
    LLVM_DEPRECATED("Use has_value instead.", "has_value")
    ^
  /home/buildbots/ppc64le-sanitizer/sanitizer-ppc64le/build/llvm-project/llvm/include/llvm/Support/Compiler.h:143:50: note: expanded from macro 'LLVM_DEPRECATED'
  #define LLVM_DEPRECATED(MSG, FIX) __attribute__((deprecated(MSG, FIX)))
                                                   ^
  /home/buildbots/ppc64le-sanitizer/sanitizer-ppc64le/build/llvm-project/lld/wasm/Driver.cpp:545:29: error: 'hasValue' is deprecated: Use has_value instead. [-Werror,-Wdeprecated-declarations]
    if (!config->memoryExport.hasValue() && !config->memoryImport.hasValue()) {
                              ^~~~~~~~
                              has_value
  /home/buildbots/ppc64le-sanitizer/sanitizer-ppc64le/build/llvm-project/llvm/include/llvm/ADT/Optional.h:325:3: note: 'hasValue' has been explicitly marked deprecated here
    LLVM_DEPRECATED("Use has_value instead.", "has_value")
    ^
  /home/buildbots/ppc64le-sanitizer/sanitizer-ppc64le/build/llvm-project/llvm/include/llvm/Support/Compiler.h:143:50: note: expanded from macro 'LLVM_DEPRECATED'
  #define LLVM_DEPRECATED(MSG, FIX) __attribute__((deprecated(MSG, FIX)))
                                                   ^
  /home/buildbots/ppc64le-sanitizer/sanitizer-ppc64le/build/llvm-project/lld/wasm/Driver.cpp:545:65: error: 'hasValue' is deprecated: Use has_value instead. [-Werror,-Wdeprecated-declarations]
    if (!config->memoryExport.hasValue() && !config->memoryImport.hasValue()) {
                                                                  ^~~~~~~~
                                                                  has_value
  /home/buildbots/ppc64le-sanitizer/sanitizer-ppc64le/build/llvm-project/llvm/include/llvm/ADT/Optional.h:325:3: note: 'hasValue' has been explicitly marked deprecated here
    LLVM_DEPRECATED("Use has_value instead.", "has_value")
    ^
  /home/buildbots/ppc64le-sanitizer/sanitizer-ppc64le/build/llvm-project/llvm/include/llvm/Support/Compiler.h:143:50: note: expanded from macro 'LLVM_DEPRECATED'
  #define LLVM_DEPRECATED(MSG, FIX) __attribute__((deprecated(MSG, FIX)))
                                                   ^
  4 errors generated.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D135898/new/

https://reviews.llvm.org/D135898