[PATCH] D137121: SPARC: Register null target streamer

[Matt Arsenault via Phabricator via llvm-commits]

arsenm created this revision.
arsenm added reviewers: koakuma, jyknight.
Herald added subscribers: jrtc27, fedor.sergeev, hiraditya.
Herald added a project: All.
arsenm requested review of this revision.
Herald added a subscriber: wdng.
Herald added a project: LLVM.

Fixes null dereference in emitFunctionBodyStart for 64-bit


https://reviews.llvm.org/D137121

Files:
  llvm/lib/Target/Sparc/MCTargetDesc/SparcMCTargetDesc.cpp
  llvm/lib/Target/Sparc/MCTargetDesc/SparcTargetStreamer.h
  llvm/test/CodeGen/SPARC/64bit.ll


Index: llvm/test/CodeGen/SPARC/64bit.ll
===================================================================
--- llvm/test/CodeGen/SPARC/64bit.ll
+++ llvm/test/CodeGen/SPARC/64bit.ll
@@ -1,5 +1,6 @@
 ; RUN: llc < %s -march=sparcv9 -mattr=+popc -disable-sparc-delay-filler -disable-sparc-leaf-proc | FileCheck %s
 ; RUN: llc < %s -march=sparcv9 -mattr=+popc | FileCheck %s -check-prefix=OPT
+; RUN: llc %s -march=sparcv9 -mattr=+popc -filetype=null
 
 ; CHECK-LABEL: ret2:
 ; CHECK: mov %i1, %i0
Index: llvm/lib/Target/Sparc/MCTargetDesc/SparcTargetStreamer.h
===================================================================
--- llvm/lib/Target/Sparc/MCTargetDesc/SparcTargetStreamer.h
+++ llvm/lib/Target/Sparc/MCTargetDesc/SparcTargetStreamer.h
@@ -22,9 +22,9 @@
 public:
   SparcTargetStreamer(MCStreamer &S);
   /// Emit ".register <reg>, #ignore".
-  virtual void emitSparcRegisterIgnore(unsigned reg) = 0;
+  virtual void emitSparcRegisterIgnore(unsigned reg){};
   /// Emit ".register <reg>, #scratch".
-  virtual void emitSparcRegisterScratch(unsigned reg) = 0;
+  virtual void emitSparcRegisterScratch(unsigned reg){};
 };
 
 // This part is for ascii assembly output
Index: llvm/lib/Target/Sparc/MCTargetDesc/SparcMCTargetDesc.cpp
===================================================================
--- llvm/lib/Target/Sparc/MCTargetDesc/SparcMCTargetDesc.cpp
+++ llvm/lib/Target/Sparc/MCTargetDesc/SparcMCTargetDesc.cpp
@@ -84,6 +84,10 @@
   return new SparcTargetAsmStreamer(S, OS);
 }
 
+static MCTargetStreamer *createNullTargetStreamer(MCStreamer &S) {
+  return new SparcTargetStreamer(S);
+}
+
 static MCInstPrinter *createSparcMCInstPrinter(const Triple &T,
                                                unsigned SyntaxVariant,
                                                const MCAsmInfo &MAI,
@@ -122,6 +126,9 @@
     // Register the asm streamer.
     TargetRegistry::RegisterAsmTargetStreamer(*T, createTargetAsmStreamer);
 
+    // Register the null streamer.
+    TargetRegistry::RegisterNullTargetStreamer(*T, createNullTargetStreamer);
+
     // Register the MCInstPrinter
     TargetRegistry::RegisterMCInstPrinter(*T, createSparcMCInstPrinter);
   }


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D137121.472156.patch
Type: text/x-patch
Size: 2184 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20221031/945b7753/attachment.bin>