[PATCH] D137101: [CodeView] Replace GHASH hasher by BLAKE3

[Reid Kleckner via Phabricator via llvm-commits]

rnk added a subscriber: akyrtzi.
rnk added a comment.

Thanks for making the code change! In our usage with clang-cl, this should appear as a small improvement in compile times.

Please add clang and lld release notes ("switched from SHA1 to BLAKE3 for PDB type hashing / -gcodeview-ghash"):
https://github.com/llvm/llvm-project/blob/main/lld/docs/ReleaseNotes.rst#id9
https://github.com/llvm/llvm-project/blob/main/clang/docs/ReleaseNotes.rst#windows-support

@akyrtzi , FYI, thanks again for adding blake3 support.



================
Comment at: llvm/lib/DebugInfo/CodeView/TypeHashing.cpp:79-80
 
-  std::array<uint8_t, 20> Hash = S.final();
-  return {ArrayRef<uint8_t>(Hash).take_back(8)};
+  std::array<uint8_t, 8> Hash = S.final();
+  return {ArrayRef<uint8_t>(Hash)};
 }
----------------
Can this just be `return {S.final()}`?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D137101/new/

https://reviews.llvm.org/D137101