[PATCH] D136872: [OpenMP][OpenMPIRBuilder] Migrate loadOffloadInfoMetadata from clang to OMPIRbuilder

Jan Sjödin via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Oct 31 11:44:28 PDT 2022


jsjodin added inline comments.


================
Comment at: llvm/lib/Frontend/OpenMP/OMPIRBuilder.cpp:4712
+    Module &M, OffloadEntriesInfoManager &OffloadEntriesInfoManager,
+    bool isDevice) {
+  // If we are in target mode, load the metadata from the host IR. This code has
----------------
isDevice must be true (add assertion at the call site) remove the parameter, and the assertions in this function. Document that this function is only intended to be used with device code generation.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D136872/new/

https://reviews.llvm.org/D136872



More information about the llvm-commits mailing list