[PATCH] D137096: [readobj] Ignore hash histogram in JSON output

Paul Kirth via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Oct 31 10:59:29 PDT 2022


paulkirth created this revision.
Herald added a reviewer: jhenderson.
Herald added a project: All.
paulkirth requested review of this revision.
Herald added subscribers: llvm-commits, MaskRay.
Herald added a project: LLVM.

Sharing the implementation with LLVMELFDumper causes us to emit
invalid JSON by printing the error message in the JSON body. Future patches can
implement the HashHistogram functionality if needed for each of the LLVM and
JSON implementations


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D137096

Files:
  llvm/tools/llvm-readobj/ELFDumper.cpp


Index: llvm/tools/llvm-readobj/ELFDumper.cpp
===================================================================
--- llvm/tools/llvm-readobj/ELFDumper.cpp
+++ llvm/tools/llvm-readobj/ELFDumper.cpp
@@ -735,6 +735,8 @@
 
   void printGroupSections() override;
 
+  void printHashHistograms() override{};
+
 private:
   std::unique_ptr<DictScope> FileScope;
 };


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D137096.472076.patch
Type: text/x-patch
Size: 359 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20221031/5c521b4e/attachment.bin>


More information about the llvm-commits mailing list