[PATCH] D137091: [readobj] Rename JSON Flag fields to be more consistent

Paul Kirth via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Oct 31 10:42:11 PDT 2022


paulkirth created this revision.
Herald added a project: All.
paulkirth requested review of this revision.
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.

Today the JSON uses `Value` and `RawValue` when printing `Flags`, when really
the `Value` field is always the name of an Enum variant, and `RawValue` is its
underlying numeric value. Similarly, we rename the `RawFlags` key to `Value`,
to match the new scheme. This also allows JSON parsing to use consistent logic
for `Flag` types.

Depends on D137089 <https://reviews.llvm.org/D137089>


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D137091

Files:
  llvm/include/llvm/Support/ScopedPrinter.h
  llvm/unittests/Support/ScopedPrinterTest.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D137091.472066.patch
Type: text/x-patch
Size: 4481 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20221031/c354f947/attachment.bin>


More information about the llvm-commits mailing list