[PATCH] D136716: [JumpThreading] Put a limit on the PHI nodes when duplicating a BB.

Eli Friedman via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Oct 31 09:08:34 PDT 2022


efriedma added a comment.

This approach seems fine.  Is there any particular reason behind the threshold 76?



================
Comment at: llvm/lib/Transforms/Scalar/JumpThreading.cpp:539
   /// Ignore PHI nodes, these will be flattened when duplication happens.
   BasicBlock::const_iterator I(BB->getFirstNonPHI());
 
----------------
Since we're iterating over the beginning of the block anyway, can we use the computed non-PHI instruction?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D136716/new/

https://reviews.llvm.org/D136716



More information about the llvm-commits mailing list