[llvm] 6495932 - [llvm] [cmake] Set EXCLUDE_FROM_ALL on gtest and TestingSupport

Michał Górny via llvm-commits llvm-commits at lists.llvm.org
Mon Oct 31 06:58:15 PDT 2022


Author: Michał Górny
Date: 2022-10-31T14:58:00+01:00
New Revision: 64959325eb470489ca5757b9bd6eef97b402a0da

URL: https://github.com/llvm/llvm-project/commit/64959325eb470489ca5757b9bd6eef97b402a0da
DIFF: https://github.com/llvm/llvm-project/commit/64959325eb470489ca5757b9bd6eef97b402a0da.diff

LOG: [llvm] [cmake] Set EXCLUDE_FROM_ALL on gtest and TestingSupport

Exclude building googletest and LLVMTestingSupport libraries from
the `all` target.  If unittests are being built, these libraries will
be built as a dependency anyway.  If they are not being built, building
them makes little sense as they are not installed or used otherwise.

This will also make standalone builds of other projects easier, as it
makes it possible to include these directories without having to cover
them with additional conditions to prevent them from being built
unconditionally.

Differential Revision: https://reviews.llvm.org/D137035

Added: 
    

Modified: 
    llvm/lib/Testing/Support/CMakeLists.txt
    llvm/utils/unittest/CMakeLists.txt

Removed: 
    


################################################################################
diff  --git a/llvm/lib/Testing/Support/CMakeLists.txt b/llvm/lib/Testing/Support/CMakeLists.txt
index 81774eb171caa..385d8eca2daa7 100644
--- a/llvm/lib/Testing/Support/CMakeLists.txt
+++ b/llvm/lib/Testing/Support/CMakeLists.txt
@@ -1,3 +1,7 @@
+# Do not build unittest libraries automatically, they will be pulled in
+# by unittests if these are built.
+set(EXCLUDE_FROM_ALL ON)
+
 add_llvm_library(LLVMTestingSupport
   Annotations.cpp
   Error.cpp

diff  --git a/llvm/utils/unittest/CMakeLists.txt b/llvm/utils/unittest/CMakeLists.txt
index 0e54e0e57c358..302e9e0e84407 100644
--- a/llvm/utils/unittest/CMakeLists.txt
+++ b/llvm/utils/unittest/CMakeLists.txt
@@ -38,6 +38,10 @@ if (HAVE_LIBPTHREAD)
   list(APPEND LIBS pthread)
 endif()
 
+# Do not build unittest libraries automatically, they will be pulled in
+# by unittests if these are built.
+set(EXCLUDE_FROM_ALL ON)
+
 add_llvm_library(llvm_gtest
   googletest/src/gtest-all.cc
   googlemock/src/gmock-all.cc


        


More information about the llvm-commits mailing list